RFR: 8151542: URL resources for multi-release jar files have a #runtime fragment appended to them
Steve Drach
steve.drach at oracle.com
Fri Apr 29 21:12:33 UTC 2016
>> I put a new webrev out with the change suggested by Paul, using file.indexOf(“!/“) instead of file.endsWith(“!/“).
>>
>> http://cr.openjdk.java.net/~sdrach/8151542/webrev.02/index.html <http://cr.openjdk.java.net/%7Esdrach/8151542/webrev.02/index.html>This still needs to be fixed to compare the URL protocol without regard to case (yes, some of the old code isn't right but best not to make it worss).
Okay.
>
>>
>>> So you are planning to eventually change the URLClassLoader spec to allow this or not?
>>
>> I think we should push this changeset since URLClassLoader has always accepted the jar:…!/ URL and all this changeset does is enable it to support multi-release jars. And create an issue to track the change to the URLClassLoader api.
>>
> There shouldn't be any urgency with this change going in but if you are doing it this way then please create a high priority bug to get the spec and implementation aligned.
Remember that I’ve not really changed anything, just enhanced what already exists to support multi-release jar files. I submitted a bug, JDK-8155770, but I marked it as P4 according to the standard classifications:
P1 - Blocks development and/or testing work, production could not run.
P2 - Crashes, loss of data, severe memory leak.
P3 - Major loss of function.
P4 - Minor loss of function, or other problem where easy workaround is present.
I just didn’t see it as any higher than P4. What would you like it to be?
More information about the core-libs-dev
mailing list