RFR: 8163373: Rewrite GenerateJLIClassesPlugin to avoid reflective calls into java.lang.invoke

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Tue Aug 9 17:30:48 UTC 2016


> MemberName defines the implementation of JavaLangInvokeAccess for some
> reason, so that's unfortunately necessary.
Oh, I see. I suggest to move the whole thing to MethodHandleImpl then.
It was exposing MemberName internals before your change, but it isn't 
anymore.

Best regards,
Vladimir Ivanov

>
>     Why did you put generateDMHClassBytes()/generateConcreteBMHClassBytes()
>     in MemberName?
>
>     Otherwise, looks fine.
>
>     Best regards,
>     Vladimir Ivanov
>
>     On 8/9/16 8:34 AM, Claes Redestad wrote:
>
>         Hi,
>
>         please review this patch to replace reflection calls into
>         java.lang.invoke from GenerateJLIClassesPlugin with an internal API
>         exported to jdk.jlink via JavaLangInvokeAccess/SharedSecrets.
>
>         Webrev: http://cr.openjdk.java.net/~redestad/8163373/webrev.01/
>         Bug: https://bugs.openjdk.java.net/browse/JDK-8163373
>
>         Thanks!
>
>         /Claes
>
>
>


More information about the core-libs-dev mailing list