RFR (JAXP) JDK-8163468: javax/xml/jaxp/unittest/validation/Bug6773084Test.java fails intermittently
Joe Wang
huizhe.wang at oracle.com
Wed Aug 10 16:48:14 UTC 2016
+1, good to identify the cause.
-Joe
On 8/10/16, 4:17 AM, Daniel Fuchs wrote:
> Hi Frank,
>
> Good analysis of the failure root cause!
>
> The proposed fix looks good to me.
>
> As a side note, are there other multi-threaded tests in JAXP?
>
> If so maybe you'll need a special method in JAXPSecurityManager
> to transfer the permissions of the current to another thread
> (I mean - find a way to make the other thread run its
> runnable in a similar runWithTmpPermission(...) call
> than the main thread, I believe InheritableThreadLocal would not
> be appropriate nor sufficient for that).
>
> JAXP multi-threaded tests might need to be revisited with that
> in mind.
>
> best regards,
>
> -- daniel
>
>
> On 10/08/16 09:06, Frank Yuan wrote:
>> Hi,
>>
>>
>>
>> Would you like to review
>> http://cr.openjdk.java.net/~fyuan/8163468/webrev.00/
>>
>> It is to fix https://bugs.openjdk.java.net/browse/JDK-8163468
>>
>>
>>
>> Please check the bug comment for the root cause, this patch moved the
>> code which requires file permission to the main test method,
>> that can guarantee to have the permission. And try to wait the
>> children threads to complete in the main test method, that make the
>> test method more graceful.
>>
>>
>>
>>
>>
>> Thanks
>>
>> Frank
>>
>
More information about the core-libs-dev
mailing list