[9] RFR 8163518: Integer overflow in StringBufferInputStream.read(byte[], int, int) and CharArrayReader.read(char[], int, int)

Aleksey Shipilev aleksey.shipilev at gmail.com
Thu Aug 11 04:09:13 UTC 2016


Yes, looks good.

Thanks,
-Aleksey

On Thu, Aug 11, 2016 at 2:20 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com>
wrote:

> Okay, I simplified that confusing part of the fix and made a minimal
> change to minimize chances of any unintended changes in behavior.
>
> http://cr.openjdk.java.net/~igerasim/8163518/02/webrev/
>
> Is it good to push now?
>
> Btw, that @requires (os.simpleArch == "x64" & os.maxMemory > XX) logic
> works quite well.
> I've seen that on different hosts one, two or all three tests were run,
> depending on the environment.
> I think, we may consider enabling some of the memory-demanding tests that
> are currently ignored.
>
> With kind regards,
> Ivan
>
>


More information about the core-libs-dev mailing list