[jdk9] RFR: 8163517: Various cleanup in java.io code

Aleksey Shipilev aleksey.shipilev at gmail.com
Tue Aug 16 13:08:37 UTC 2016


On 08/16/2016 03:53 PM, Ivan Gerasimov wrote:
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8163517
> WEBREV: http://cr.openjdk.java.net/~igerasim/8163517/00/webrev/

Both ObjectInputStream and ObjectOutputStream can use auto-unboxing in
these blocks?

1271         if (result.booleanValue()) {
1272             return;
1273         }

ObjectStreamClass:

I wonder if the entire getPackageName is replaceable with
Class.getPackageName()? If so, ditch the method completely and use
Class.getPackageName everywhere. This may complicate backporting to JDK
8 though.

OutputStreamWriter:

New code in append(CharSequence,int,int) unnecessarily calls toString on
CharBuffers which are handled specially downstream in append(CharSequence).

Thanks,
-Aleksey





More information about the core-libs-dev mailing list