RFR 8163798: Add a versionedStream method to JarFile

Andrej Golovnin andrej.golovnin at gmail.com
Fri Aug 26 06:05:37 UTC 2016


Hi Steve,

in the line

597         Map<Integer,List<Name>> versionsMap = stream()

I miss space after the comma.

In the line

626         return finalNames.stream().map(nm -> getJarEntry(nm));

You can use a method reference instead of lambda:

626         return finalNames.stream().map(this::getJarEntry);

And if you add a method #getName() to the Name class,
then you can use method references in the lines 604 and 614 too.


+1 to Tagir's suggestions.


Best regards,
Andrej Golovnin


More information about the core-libs-dev mailing list