8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

[Aleks Efimov]

Hi Christoph,

Thanks for the review and suggestion. I've converted 'shutdown' and 
'shutdownNow' calls to use method references.

Best Regards,

Aleksej


On 31/08/16 11:34, Langer, Christoph wrote:
> Hi Aleks,
>
> looks nice to me.
>
> You could maybe use the method reference syntax in 2 places:
>
> --- a/test/javax/xml/jaxp/unittest/common/WarningsTestBase.java Wed Aug 31 09:17:55 2016 +0200
> +++ b/test/javax/xml/jaxp/unittest/common/WarningsTestBase.java Wed Aug 31 10:32:05 2016 +0200
> @@ -68,11 +68,11 @@
>               EXECUTOR.execute(new TestWorker(id));
>           }
>           //Initiate shutdown of previously submitted task
> -        runWithAllPerm(() -> EXECUTOR.shutdown());
> +        runWithAllPerm(EXECUTOR::shutdown);
>           //Wait for termination of submitted tasks
>           if (!EXECUTOR.awaitTermination(THREADS_COUNT, TimeUnit.SECONDS)) {
>               //If not all tasks terminates during the time out force them to shutdown
> -            runWithAllPerm(() -> EXECUTOR.shutdownNow());
> +            runWithAllPerm(EXECUTOR::shutdownNow);
>           }
>           //Restore default standard error stream
>           runWithAllPerm(() -> System.setErr(defStdErr));
>
> But the Lambda expression might be more consistent, too.
>
> I'm not a reviewer though...
>
> Best regards
> Christoph
>
>> -----Original Message-----
>> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On Behalf
>> Of Aleks Efimov
>> Sent: Dienstag, 30. August 2016 21:01
>> To: core-libs-dev <core-libs-dev at openjdk.java.net>
>> Subject: RFR: 8150145:
>> javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and
>> ValidationWarningsTest.java failed intermittently without any error message
>>
>> Hello,
>>
>> Please, help to review the tests fix.
>> Webrev: http://cr.openjdk.java.net/~aefimov/8150145/00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8150145
>>
>> The list of changes:
>> 1. Two tests were modified to print exception occurred during execution.
>> Before that these tests were failing silently.
>> 2. The tests were slightly modified to correctly run with security
>> manager run mode recently added to JAXP tests (JDK-8067170).
>> 3. TransformationWarningsTest were modified to synchronize the
>> TransformerFactory instantiation.
>>
>> The modified tests were executed 2000+ times (alongside to other tests
>> from jaxp/test/javax/xml/jaxp/unittest/common) on linux-x64 and there
>> were no failures observed. According to this result and that the tests
>> were modified not to fail silently. I would like to remove these two
>> tests from the jaxp problem list.
>> If the tests will continue to fail on some configurations (JPRT shows no
>> failures for few runs though) the proposed changes will help to diagnose
>> the cause of failures.
>>
>> With Best Regards,
>> Aleksej