RFR JDK-8167328: jar -d m.jar hangs

Mandy Chung mandy.chung at oracle.com
Thu Dec 1 19:58:18 UTC 2016


> On Nov 30, 2016, at 4:48 PM, Xueming Shen <xueming.shen at oracle.com> wrote:
> 
> Hi,
> 
> Please help review the change for #8167328
> 
> issue: https://bugs.openjdk.java.net/browse/JDK-8167328
> webrev: http://cr.openjdk.java.net/~sherman/8167328
> 
> It appears the desired behavior is to throw the error + help msg if the
> option "--print-module-descriptor"/ "-d" is specified with some extra
> file names.

This looks good.

It may be useful to include the arguments in the error message:

  48         '-d, --print-module-descriptor' option requires no input files to be specified!

Mandy



More information about the core-libs-dev mailing list