RFR(s): 8170664: SystemLoggerInPlatformLoader.java failing in case of module limitation

[Sergei Kovalev]

Hi Daniel,

Please take a look at 
http://cr.openjdk.java.net/~skovalev/8170664/webrev.01/

This simplify logic a bit. What if JDK uses some custom logging library 
instead of java.logging? Looks like in this case the test will expect 
SimpleConsoleLogger but it could be not a case. Isn't it? Does it matter 
for testing?

-- 
With best regards,
Sergei

05.12.16 21:40, Daniel Fuchs wrote:
> On 05/12/16 14:50, Sergei Kovalev wrote:
>> Hi Team,
>>
>> Could you please review a small change for regression test?
>
> Hi Sergei,
>
> Could you try with:
>
> if (Layer.boot().findModule("java.logging").isPresent()) {
>     // expect JdkLazyLogger
> } else {
>     // expect SimpleConsoleLogger
> }
>
> That shouldn't require any usage of jdk.internal APIs.
>
> best regards,
>
> -- daniel
>
>>
>> BugID: JDK-8170664
>> Webrev: http://cr.openjdk.java.net/~skovalev/8170664/webrev.00/
>>
>> Issue: One test fails in case of usage command line option
>> "--limit-module java.base".
>> Summary: The test has written in assumption that JDK always has
>> java.util.logging module on board. In reality we can limit JDK by
>> java.base only. In this case JDK will have only SimpleConsoleLogger on
>> board and the test failing. The fix adds a check for limited logging
>> ability and introduce a separate branch in the test for
>> SimpleConsoleLogger case.
>>
>