RFR 8169653: Restore ObjectInputStream::resolveClass call stack default search order

Daniel Fuchs daniel.fuchs at oracle.com
Tue Dec 6 13:00:54 UTC 2016


Hi Chris,

Looks good. I wonder about the two different links for
platform class loader now.

Should the first one perhaps include "nor its ancestor" in
the link text?

best regards,

-- daniel

On 06/12/16 12:25, Chris Hegarty wrote:
>
>> On 6 Dec 2016, at 11:53, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>>
>> Hi Chris,
>>
>> I have an additional suggestion: could you update the
>> comment of the private ObjectInputStream::latestUserDefinedLoader()
>> in the same file to align with what the method is actually
>> doing?
>>
>> I looked at what jdk.internal.misc.VM.latestUserDefinedLoader()
>> does, and the comment in ObjectInputStream::latestUserDefinedLoader()
>> doesn't seem to match the implementation.
>
> Right, the comment is now outdated and needs a refresh. I did this, along with
> removing the comment about the dependency from corba which was removed
> by 8164908 [1] ( which you pointed out off line ).
>
> Moved into a webrev, as the changes have grown a little:
>   http://cr.openjdk.java.net/~chegar/8169653.00/
>
> -Chris.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8164908
>



More information about the core-libs-dev mailing list