RFR(s): 8170664: SystemLoggerInPlatformLoader.java failing in case of module limitation
Mandy Chung
mandy.chung at oracle.com
Tue Dec 6 17:30:27 UTC 2016
> On Dec 6, 2016, at 1:36 AM, Sergei Kovalev <sergei.kovalev at oracle.com> wrote:
>
> Hi Daniel,
>
> Please take a look at http://cr.openjdk.java.net/~skovalev/8170664/webrev.01/
109 boolean simleConsoleOnly = !Layer.boot().findModule("java.logging").isPresent();
typo: s/simle/simple
107 Class sploggerType = splogger.getClass();
:
123 Class sloggerType = slogger.getClass();
124 System.out.println("slogger: " + sloggerType);
125 if (sloggerType.equals(sploggerType)) {
This check is redundant. Is this the intended check?
Assuming the above check is not needed, you can further simplify something like this:
String expectedType = Layer.boot().findModule("java.logging").isPresent()
? "SimpleConsoleLogger" : "JdkLazyLogger”;
Mandy
More information about the core-libs-dev
mailing list