Ping - Re: RFR 8043838, Test java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java failed intermittently in nightly
Chris Hegarty
chris.hegarty at oracle.com
Wed Dec 7 14:50:21 UTC 2016
> On 7 Dec 2016, at 14:48, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>
> Hi Felix,
>
> Looks good in general, but is
> 74 return;
> intended, or is that a test bug?
It is intended, as that is the code path that will be executed when the test
invokes itself.
-Chris.
> best regards,
>
> -- daniel
>
> On 07/12/16 14:29, Felix Yang wrote:
>> :-)
>>
>> -Felix
>>> On 6 Dec 2016, at 9:28 AM, Felix Yang <felix.yang at oracle.com> wrote:
>>>
>>> Add core-libs.
>>>
>>> Thanks,
>>> Felix
>>> On 2016/12/5 22:14, Felix Yang wrote:
>>>> Hi,
>>>>
>>>> updated webrev. May I have a reviewer to review this
>>>>
>>>> http://cr.openjdk.java.net/~xiaofeya/8043838/webrev.01/
>>>>
>>>> -Felix
>>>> On 2016/12/5 15:50, Felix Yang wrote:
>>>>>
>>>>>
>>>>> On 2016/12/5 15:47, Langer, Christoph wrote:
>>>>>> Hi Felix,
>>>>>>
>>>>>> looks ok to me.
>>>>>>
>>>>>> You probably should remove the reference to the old shell script in comment line 25, though:
>>>>>>
>>>>>> 25 * Test run from script, AcceptCauseFileDescriptorLeak.sh
>>>>> Christoph, Good catch!
>>>>>
>>>>> Thanks,
>>>>> Felix
>>>>>>
>>>>>> Best regards
>>>>>> Christoph
>>>>>
>>>>
>>>
>>
>
More information about the core-libs-dev
mailing list