Review Request JDK-8170772: ResourceBundle improper caching causes tools/javadoc tests intermittently

Naoto Sato naoto.sato at oracle.com
Fri Dec 9 18:25:51 UTC 2016


Hi Mandy,

The fix looks fine to me.

Naoto

On 12/9/16 10:05 AM, Daniel Fuchs wrote:
> Hi Mandy,
>
> It will be good to have Naoto's opinion on this.
> But what you propose makes sense to me.
>
> best regards,
>
> -- daniel
>
> On 09/12/16 16:49, Mandy Chung wrote:
>> Naoto,
>>
>> Can you review this ResourceBundle caching fix?  The caller module
>> may be different than the specified module to
>> ResourceBundle.getBundle(String, Module) method and it should also
>> part of the cache key.
>>
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8170772/webrev.00/
>>
>> The new test shows the issue there and the first loading of the
>> resource bundle of a specific module (success or fail) will be
>> put in the cache and used by subsequent calls.
>>
>> Thanks
>> Mandy
>>
>


More information about the core-libs-dev mailing list