RFR (JAXP) 8146271: File system contention in debug print via XPathFactory.newInstance

[Langer, Christoph]

+1

This is cool :)

> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On Behalf
> Of Joe Wang
> Sent: Mittwoch, 14. Dezember 2016 20:26
> To: Aleks Efimov <aleksej.efimov at oracle.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: Re: RFR (JAXP) 8146271: File system contention in debug print via
> XPathFactory.newInstance
> 
> Hi Aleksej,
> 
> Looks good. Thanks for covering the whole packages!
> 
> Best,
> Joe
> 
> On 12/14/16, 10:04 AM, Aleks Efimov wrote:
> > Hi Joe,
> >
> > Thank you for the suggestions. What about modifying the 'debugPrintln'
> > and 'dPrint' functions to accept 'j.u.function.Supplier<String>'
> > instead of 'String'? Such approach will give us a possibility to do
> > the output string calculation only when debugging is switched on. Such
> > approach can be illustrated by this webrev:
> > http://cr.openjdk.java.net/~aefimov/8146271/9/01
> >
> > Best Regards,
> > Aleksej
> >
> >
> > On 14/12/16 03:35, Joe Wang wrote:
> >> Hi Aleksej,
> >>
> >> You may want to improve the debugPrintln or its usage to remove the
> >> String concatenations or method calls such as f.getClass().getName()
> >> that are unnecessary when debug == false. Where we are here, could
> >> you expand the patch to cover other jaxp packages (e.g.
> >> javax.xml.parsers) where similar problems exist.
> >>
> >> Best,
> >> Joe
> >>
> >> On 12/13/16, 3:02 PM, Aleks Efimov wrote:
> >>> Hello,
> >>>
> >>> Please, help to review the changes that addresses the file system
> >>> contention caused by debug code in XPathFactoryFinder and
> >>> XPathFactoryFinder classes [1]. Proposed fix wraps the debug output
> >>> code in "if(debug)" block:
> >>> http://cr.openjdk.java.net/~aefimov/8146271/9/00/
> >>>
> >>> Best Regards,
> >>> Aleksej
> >>>
> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8146271
> >>>
> >