RFR: jsr166 jdk9 integration wave 13

Doug Lea dl at cs.oswego.edu
Thu Dec 15 17:35:04 UTC 2016


On 12/15/2016 07:36 AM, Stefan Zobel wrote:
> SubmissionPublisherTest, line 420: "s1.awaitSubscribe();"
>
> I might be wrong, shouldn't this be "s2.awaitSubscribe();"?
>

Thanks. Changed.
Using s1 on that line wasn't wrong, but wasn't intentional.
(The first use of s1 catches error-before-subscribe; the
"s2" cases just check against side effects, but they should
use s2 consistently for uniformity.)

-Doug


>
> Regards,
> Stefan
>
>
> 2016-12-14 0:13 GMT+01:00 Martin Buchholz <martinrb at google.com>:
>> We were supposed to be winding down jdk9, and there are a lot of changes
>> here, but ... it would be a shame not to have fast specialized
>> implementations for new collection methods added in Java 8.  There's also a
>> fix for a serious bug in LinkedBlockingQueue.
>>
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/
>>
>> As with wave 12, very collection oriented.
>



More information about the core-libs-dev mailing list