JDK 9 RFR of JDK-8139688 Port fdlibm exp to Java

joe darcy joe.darcy at oracle.com
Sat Dec 17 05:44:23 UTC 2016


Hi Brian,


On 12/16/2016 10:43 AM, Brian Burkhalter wrote:
> Hi Joe,
>
> This looks fine to me. I’ve just a few picayune items:
>
> 1. FdLibm
>
> Line 649: I assume the weird “halF” (upper case F) is retained in 
> order to match the original C code.

Corrected.

>
> 2. TEST.ROOT
>
> Line 30: The jtreg required version is reverted.

Oops; I'll fix that before pushing.

>
> 3. ExpTests
>
> Lines 65 and 69: The threshold values in comments could be static 
> final constants as well as they are used at lines
> 66, 70, 109 and 112.

Yeah, I went back and forth on that point a bit while write the test. I 
changed the later usages to

         double[] decisionPoints = {
             // Near overflow threshold
             EXP_OVERFLOW_THRESH - 512*Math.ulp(EXP_OVERFLOW_THRESH),

             // Near underflow threshold
             EXP_UNDERFLOW_THRESH - 512*Math.ulp(EXP_UNDERFLOW_THRESH),

Thanks,

-Joe



More information about the core-libs-dev mailing list