RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations
ShinyaYoshida
bitterfoxc at gmail.com
Wed Feb 3 12:11:11 UTC 2016
Hi Nadeesh,
Almost LGTM!(But I'm not a reviewer;) )
However I've noticed that you don't use NANOS_PER_SECOND at L1223 and L1246.
Is there some reason not to use it?
Regards,
shinyafox(Shinya Yoshida)
2016-02-01 15:18 GMT+09:00 nadeesh tv <nadeesh.tv at oracle.com>:
> Hi all,
>
> Please review following
>
> Bug Id : https://bugs.openjdk.java.net/browse/JDK-8146747 <
> https://bugs.openjdk.java.net/browse/JDK-8146747>
>
> Solution: Handled the negative duration separately
>
> webrev : http://cr.openjdk.java.net/~ntv/8146747/webrev.00/ <
> http://cr.openjdk.java.net/%7Entv/8146747/webrev.00/>
>
> --
> Thanks and Regards,
> Nadeesh TV
>
>
More information about the core-libs-dev
mailing list