RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

nadeesh tv nadeesh.tv at oracle.com
Thu Feb 4 05:27:31 UTC 2016


Hi all,

Please see the updated webrev 
http://cr.openjdk.java.net/~ntv/8146747/webrev.01/
Regards,
Nadeesh
On 2/3/2016 5:48 PM, nadeesh tv wrote:
> Hi Shinya,
> Thnx. I will update it.
> Regards,
> Nadeesh
> On 2/3/2016 5:41 PM, ShinyaYoshida wrote:
>> Hi Nadeesh,
>> Almost LGTM!(But I'm not a reviewer;) )
>> However I've noticed that you don't use NANOS_PER_SECOND at L1223 and 
>> L1246.
>> Is there some reason not to use it?
>>
>> Regards,
>> shinyafox(Shinya Yoshida)
>>
>> 2016-02-01 15:18 GMT+09:00 nadeesh tv <nadeesh.tv at oracle.com 
>> <mailto:nadeesh.tv at oracle.com>>:
>>
>>     Hi all,
>>
>>     Please review following
>>
>>     Bug Id : https://bugs.openjdk.java.net/browse/JDK-8146747
>>     <https://bugs.openjdk.java.net/browse/JDK-8146747>
>>
>>     Solution: Handled the negative duration separately
>>
>>     webrev : http://cr.openjdk.java.net/~ntv/8146747/webrev.00/
>>     <http://cr.openjdk.java.net/%7Entv/8146747/webrev.00/>
>>     <http://cr.openjdk.java.net/%7Entv/8146747/webrev.00/>
>>
>>     --     Thanks and Regards,
>>     Nadeesh TV
>>
>>
>

-- 
Thanks and Regards,
Nadeesh TV




More information about the core-libs-dev mailing list