RFR 9: 8142539 : Incorrect definition of ZoneOffset.MIN and other javadoc cleanup

Stephen Colebourne scolebourne at joda.org
Wed Feb 10 22:05:19 UTC 2016


The plusHours() change loses something in the fix. previously, it had
an example for summer-to-summer, summer-to-winter, and
winter-to-winter. Now the last of these has gone. This would be
better:

<li>Adding one hour to 01:30+02:00 will result in 02:30+02:00 (both in
summer time)
<li>Adding one hour to 02:30+02:00 will result in 02:30+01:00 (moving
from summer to winter time)
<li>Adding one hour to 02:30+01:00 will result in 03:30+01:00 (both in
summer time)
<li>Adding three hours to 01:30+02:00 will result in 03:30+01:00
(moving from summer to winter time)

other changes look fine
thanks
Stephen


On 10 February 2016 at 20:25, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Please review a trio of javadoc fixes for java.time.
>
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-typos-8142539/
>
> Issues:
>    8142539: Incorrect definition of ZoneOffset.MIN
>    8140211: Example in the Documentation is wrong for
> java.time.ZonedDateTime.minusHours
>    8139529: java.time.temporal.ChronoUnit.FOREVER typo
>
> Thanks, Roger
>



More information about the core-libs-dev mailing list