RFR 8144931: Assert class signatures are correct and refer to valid classes

[Paul Sandoz]

> On 18 Feb 2016, at 12:18, shilpi.rastogi at oracle.com wrote:
> 
> Thank You Vladimir!
> 
> I have done the changes. Please review the updated patch-
> 
> http://cr.openjdk.java.net/~srastogi/8144931/webrev.02/
> 

Looking good. There are also a few other cases in InvokerBytecodeGenerator you can update:

 679                         mv.visitAnnotation("Ljava/lang/invoke/InjectedProfile;", true);


1328         // Suppress this method in backtraces displayed to the user.
1329         mv.visitAnnotation("Ljava/lang/invoke/LambdaForm$Hidden;", true);
1330
1331         // Don't inline the interpreter entry.
1332         mv.visitAnnotation("Ljdk/internal/vm/annotation/DontInline;", true);


1387         // Suppress this method in backtraces displayed to the user.
1388         mv.visitAnnotation("Ljava/lang/invoke/LambdaForm$Hidden;", true);
1389
1390         // Force inlining of this invoker method.
1391         mv.visitAnnotation("Ljdk/internal/vm/annotation/ForceInline;", true);
1392

That might be all the rest but i have not double checked.

As a follow on task can you check other classes in j.l.i where this technique might be applied? if so we can log another issue for that e.g search using the regex \"L[\w\/]+;\”.

Paul.

> Regards,
> Shilpi
> 
> On 2/18/2016 1:58 PM, Vladimir Ivanov wrote:
>> Shilpi,
>> 
>> _CLASS suffix looks redundant and you can abbreviate LAMBDA_FORM to LF:
>>  LF_HIDDEN_SIG
>>  LF_COMPILED_SIG
>>  FORCEINLINE_SIG
>>  DONTINLINE_SIG
>> 
>> Otherwise, looks fine.
>> 
>> Best regards,
>> Vladimir Ivanov
>> 
>> On 2/17/16 5:47 PM, shilpi rastogi wrote:
>>> Hi All,
>>> 
>>> Please review fix for the following bug-
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8144931
>>> http://cr.openjdk.java.net/~srastogi/8144931/webrev.01/
>>> 
>>> 
>>> Thanks,
>>> Shilpi
>