RFR: 8144062: Determine appropriate module for jdk.Version

Mandy Chung mandy.chung at oracle.com
Thu Feb 25 18:49:48 UTC 2016


> On Feb 24, 2016, at 9:59 PM, Iris Clark <iris.clark at oracle.com> wrote:
> 
> Hi, Alan, Mandy, and Mark.
> 
> After exploring a few module options (jdk.Version, jdk.dev [0]), 
> it looks like the best choice is to move jdk.Version to 
> java.lang.Runtime.Version (a nested class of Runtime).  It supports 
> the values returned by the java.{vm.}?version and 
> java.{vm.}?specification.version system properties.  By making 
> Version an SE API, it may be exported by the java.base module.
> 
> Please review the following changes to move jdk.Version to 
> jdk.lang.Runtime.Version.  Note that beyond the package name and
> class declaration (to static), the only other changes in Version
> are related to indentation.
> 
> Bug
> 
>    8144062: Determine appropriate module for jdk.Version
>    https://bugs.openjdk.java.net/browse/JDK-8144062
> 
> webrev
> 
>    http://cr.openjdk.java.net/~iris/verona/8144062/webrev.0/

942      * A representation of the JDK version-string

version string for the runtime instead of JDK

One suggestion is to move the details about fourth and later elements to @implSpec or @implNote.

Have you considered moving the static Version::current method to Runtime::version?

Mandy




More information about the core-libs-dev mailing list