RFR: JDK-8068803:Performance of LocalDate.plusDays could be better

nadeesh tv nadeesh.tv at oracle.com
Thu Jan 7 09:20:17 UTC 2016


Hi ,
Please see the updated webrev 
http://cr.openjdk.java.net/~ntv/8068803/webrev.01/
Thanks and regards,
Nadeesh
On 1/6/2016 12:11 AM, Roger Riggs wrote:
> Hi Nadeesh,
>
> LocalDate.java: +1374:
>   For the most common case of dom > 0 && <= 28, I would have 
> explicitly and immediately returned the new LocalDate.
>       if (dom > 0 && dom <= 28) {
>            return LocalDate.of(year, month, (int) dom);
>       }
>       ...
>
> TCKLocalDate.java:
>  - Since the test_plusDays_normal is being replaced, its test case 
> should be included in the DataProvider
>        {LocalDate.of(2007, 7, 15), 1, LocalDate.of(2007, 7, 16)}
> Thanks, Roger
>
> On 1/5/2016 1:05 PM, nadeesh tv wrote:
>> Hi all,
>>
>> Please review  a  fix for 
>> https://bugs.openjdk.java.net/browse/JDK-8068803
>>  web rev : http://cr.openjdk.java.net/~ntv/8068803/webrev.00/
>>
>> Special thanks for Stephen for  providing the source code patch
>>
>

-- 
Thanks and Regards,
Nadeesh TV




More information about the core-libs-dev mailing list