RFR (M): 8135250: Replace custom check/range functionality with check index/range methods in java.util.Arrays

[Kharbas, Kishor]

Thanks Paul for reviewing it. And thanks for offering to create a issue, I myself don't have the permissions on JBS, so I can use your help :-)

For now IndexOutOfBoundsException looks ok; like you said I will revisit this functionality when exception message reported by the API is changed.

Thanks,
Kishor

-----Original Message-----
From: Paul Sandoz [mailto:paul.sandoz at oracle.com] 
Sent: Thursday, January 07, 2016 12:28 AM
To: Kharbas, Kishor
Cc: Anthony Scarpino; core-libs-dev at openjdk.java.net
Subject: Re: RFR (M): 8135250: Replace custom check/range functionality with check index/range methods in java.util.Arrays


> On 7 Jan 2016, at 09:15, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:
> 
> Hi Kishor,
> 
> Looks good to me. A small but nice improvement.
> 
> I guess you are ok with these throwing IndexOutOfBounds rather than ArrayIndexOutOfBounds.
> 

Actually i just realised you are reusing issue JDK-8135250, which is logged to track a wider range of identified areas in the JDK. Would it be possible to create a new issue [*] related to JDK-8135250 just for the crypto stuff.

Paul.

[*] If you don’t have the "power ups” to do that i can create one for you.

> —
> 
> Note that i am going to revisit the exception message reporting and with nudging by John the BiFunction to ensure no bounds information is lost. It should not affect this code, but should produce better error messages, and after it might be an opportunity to revisit if you want these to throw ArrayIndexOutOfBounds.
> 
> Paul.
> 
>> On 7 Jan 2016, at 01:18, Kharbas, Kishor <kishor.kharbas at intel.com> wrote:
>> 
>> Hello all,
>> 
>> Requesting the community to review a patch which replaces custom bound checking functionality with calls to methods in java.util.Objects.
>> 
>> The methods affected are CounterMode.crypt() and AESCrypt.encryptBlock(), AESCrypt.decryptBlock()
>> 
>> 
>> Bug id:
>> https://bugs.openjdk.java.net/browse/JDK-8135250
>> Webrev:
>> http://cr.openjdk.java.net/~vdeshpande/8135250/webrev.00/
>> 
>> Regards
>> Kishor Kharbas
>