RFR: JDK-8144144 - ORB destroy() leaks filedescriptors after unsuccessful connection

[Seán Coffey]

Looks good to me Mark. Chris's point will help clean up the new 
clearDeferredRegistrations method.

Is this close operation applicable only to the inboundConnectionCaches ? 
I guess that one creates the ServerSocket for the acceptor. Does any 
such socket get created/left behind for the outboundConnectionCaches ?

Regards,
Sean.

On 11/01/2016 06:32, Chris Hegarty wrote:
> On 8 Jan 2016, at 17:49, Mark Sheppard <mark.sheppard at oracle.com> wrote:
>
>> Hi
>>    please oblige and review the following changes
>> http://cr.openjdk.java.net/~msheppar/8144144/webrev/
> In SelectorImpl.clearDeferredRegistrations() there is no need to call close()
> on the Socket returned from channel.socket(), since you have already
> closed the channel.
>
> -Chris.
>
>> which addresses the issue
>> https://bugs.openjdk.java.net/browse/JDK-8144144
>>
>> the changes ensure that an Acceptor and its associated ServerSocket/ServerSocketChannel
>> are closed.
>>
>> regards
>> Mark