RFR:JDK-8141452:Convert between TimeUnit and ChronoUnit

Roger Riggs Roger.Riggs at Oracle.com
Mon Jan 25 16:54:00 UTC 2016


Hi Stephen, Nadeesh,

TimeUnit.toChronoUnit is a static method.  It seems redundant to have to 
pass an instance to a static method of its type.
      cu = TimeUnit.toChronoUnit(TimeUnit.SECONDS);

Instead of:
    TimeUnit tu = TimeUnit.SECONDS;
     ChronoUnit  cu = tu.toChronoUnit();


Minor edits please:

in @param and @return use the type name when referring to the type.
For example, TimeUnit vs timeUnit (the parameter).

in @throws, use the parameter name instead of "the unit";
For example,

+ * @throws IllegalArgumentException if timeUnit cannot be converted 
Thanks, Roger


On 1/25/2016 11:06 AM, nadeesh tv wrote:
> Hi all,
>
> Please see the updated webrev 
> http://cr.openjdk.java.net/~ntv/8141452/webrev.00/
>
> -- 
> Thanks and Regards,
> Nadeesh TV
>
>
> On 1/25/2016 9:01 PM, Stephen Colebourne wrote:
>> Typo "TimeUnitequivalent"
>> Otherwise looks good.
>> thanks
>> Stephen
>>
>>
>>
>> On 25 January 2016 at 15:25, nadeesh tv <nadeesh.tv at oracle.com> wrote:
>>
>>> Hi all,
>>>
>>> Please review a fix for conversion between Chronounit and Timeunit
>>>
>>> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8141452
>>>
>>> webrev: http://cr.openjdk.java.net/~ntv/8141452/webrev.00/
>>>
>>> -- 
>>> Thanks and Regards,
>>> Nadeesh TV
>>>
>>>
>




More information about the core-libs-dev mailing list