RFR [9]: 8145104: NPE is thrown when JAXBContextFactory implementation is specified in system property, 8145112: newInstance(String, ClassLoader): java.lang.JAXBException should not be wrapped as expected according to spec

[Lance Andersen]

Hi Miran,

Sorry for the delay in the review.  Lost it over the holidays…

Overall it looks good.  I probably would have used TestNG  but I understand these are not just openjdk specific tests so all is good.

Please remember to bump the copyright date from 2015 to 2016

Best
Lance
On Jan 28, 2016, at 5:40 AM, Miroslav Kos <miroslav.kos at oracle.com> wrote:

> Hi Lance,
> this is the RFR Alan was mentioning.
> 
> Thanks a lot!
> Miran
> 
> 
> On 11/01/16 12:14, Miroslav Kos wrote:
>> Ping ... anybody?
>> 
>> On 22/12/15 14:44, Miroslav Kos wrote:
>>> Hi everybody,
>>> I'd like to ask for reviewing following patch. It fixes two issues:
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8145104
>>> NPE is thrown when JAXBContextFactory implementation is specified in system property
>>> 
>>> In short, it's a regression of recent changes in JAXB-AP. The old version of API is using static methods to create JAXBContext instance, where as the new configuration facility uses defined interface. The methods are called via core reflection, so when invoking non-static method of spi implemetation, instance of the spi must be created first. This fixes NPE which occured in certain scenarios.
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8145112
>>> newInstance(String, ClassLoader): java.lang.JAXBException should not be wrapped as expected according to spec
>>> 
>>> There are still some changes in javadoc being discussed, but anyway this double-wrapping exception into JAXBException doesn't make any sense. JAXBException thrown from JAXB spi provider is re-thrown as is.
>>> 
>>> Fix: http://cr.openjdk.java.net/~mkos/8145104/jaxws.01/
>>> Tests: http://cr.openjdk.java.net/~mkos/8145104/jdk.02/
>>> 
>>> Added 2 new jtreg tests, the tests added also to standalone project.
>>> 
>>> Thanks
>>> Miran
>>> 
>> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com