RFR:JDK-8141452:Convert between TimeUnit and ChronoUnit

[Chris Hegarty]

On 29/01/16 14:52, Roger Riggs wrote:
> Hi Nadeesh,
>
> Looks fine,
>
> Thanks, Roger
>
>
> On 1/27/2016 11:34 AM, nadeesh tv wrote:
>> Hi all,
>>
>> Thanks for the suggestions.
>> Please see the updated webrev
>> http://cr.openjdk.java.net/~ntv/8141452/webrev.01/

+1  This looks fine.

Martin, Doug,

   I assume you are ok to accept this small change in 
java.util.concurrent.TimeUnit.

-Chris.

>> Regards,
>> Nadeesh TV
>>
>> On 1/25/2016 10:24 PM, Roger Riggs wrote:
>>> Hi Stephen, Nadeesh,
>>>
>>> TimeUnit.toChronoUnit is a static method.  It seems redundant to have
>>> to pass an instance to a static method of its type.
>>>      cu = TimeUnit.toChronoUnit(TimeUnit.SECONDS);
>>>
>>> Instead of:
>>>    TimeUnit tu = TimeUnit.SECONDS;
>>>     ChronoUnit  cu = tu.toChronoUnit();
>>>
>>>
>>> Minor edits please:
>>>
>>> in @param and @return use the type name when referring to the type.
>>> For example, TimeUnit vs timeUnit (the parameter).
>>>
>>> in @throws, use the parameter name instead of "the unit";
>>> For example,
>>> + * @throws IllegalArgumentException if timeUnit cannot be converted
>>> Thanks, Roger
>>>
>>> On 1/25/2016 11:06 AM, nadeesh tv wrote:
>>>> Hi all,
>>>>
>>>> Please see the updated webrev
>>>> http://cr.openjdk.java.net/~ntv/8141452/webrev.00/
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Nadeesh TV
>>>>
>>>>
>>>> On 1/25/2016 9:01 PM, Stephen Colebourne wrote:
>>>>> Typo "TimeUnitequivalent"
>>>>> Otherwise looks good.
>>>>> thanks
>>>>> Stephen
>>>>>
>>>>>
>>>>>
>>>>> On 25 January 2016 at 15:25, nadeesh tv <nadeesh.tv at oracle.com> wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> Please review a fix for conversion between Chronounit and Timeunit
>>>>>>
>>>>>> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8141452
>>>>>>
>>>>>> webrev: http://cr.openjdk.java.net/~ntv/8141452/webrev.00/
>>>>>>
>>>>>> --
>>>>>> Thanks and Regards,
>>>>>> Nadeesh TV
>>>>>>
>>>>>>
>>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Nadeesh TV
>>
>