RFR: 8148570: TzdbZoneRulesCompiler.java throws Null Pointer Exception While Compiling and building TZDB data file

[Ramanand Patil]

Hi Roger,

 

Writing the regression test will be little tricky, because the transition rules are read from the IANA provided tzdata files and during JDK building the tzdb.dat file is created.

This issue was actually found after JDK9 build failure with integrated tzdata2016a files.

Being a very obvious trivial bug fix, I feel this should be Ok without test.

I have updated the label to include 'noreg-trivial'.

 

Regards,

Ramanand.

 

 

-----Original Message-----
From: Roger Riggs 
Sent: Friday, January 29, 2016 11:43 PM
To: core-libs-dev at openjdk.java.net
Subject: Re: RFR: 8148570: TzdbZoneRulesCompiler.java throws Null Pointer Exception While Compiling and building TZDB data file

 

Hi Ramanand,

 

Is there a specific regression test that can be written for the case?

 

Otherwise, looks fine.

 

Roger

 

 

On 1/29/2016 12:56 PM, Ramanand Patil wrote:

> HI all,

> 

> Please review this trivial fix for Bug  - https://bugs.openjdk.java.net/browse/JDK-8148570

> 

> Bug Description - While compiling and building TZDB data file(tzdata2016a) when transition rule(for Iran) doesn't have the day-of-week data a null pointer exception is thrown.

> 

> Webrev - http://cr.openjdk.java.net/~rpatil/8148570/webrev.00/

> 

> Fix - While getting value from DayOfWeek, -1 is returned if the DayOfWeek is null. The reason to return "-1" being, the same value is checked later while getting day-of-week byte (dowbyte) at line no. 251, ZoneRules.java.

> 

>   

> 

> Regards,

> 

> Ramanand.

> 

>   

> 

>