[9] RFR: 8154553: Incorrect GPL header in package-info.java reported

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Jul 4 23:26:10 UTC 2016


Hi Aleks!

Is it the only mistake detected by that script?
Again, grep finds a few more similar typos in the copyright headers:

java.desktop/share/classes/sun/awt/RequestFocusController.java: * 
Copyright (c) 2006, 2016 Oracle and/or its affiliates. All rights reserved.
java.desktop/unix/native/libawt_xawt/xawt/gnome_interface.h: * Copyright 
(c) 2013, 2016 Oracle and/or its affiliates. All rights reserved.
java.management/share/classes/javax/management/ConstructorParameters.java: 
* Copyright (c) 2006, 2015 Oracle and/or its affiliates. All rights 
reserved.
jdk.accessibility/share/classes/com/sun/java/accessibility/util/package-info.java: 
* Copyright (c) 2013, 2015 Oracle and/or its affiliates. All rights 
reserved.
java.base/macosx/classes/java/lang/ClassLoaderHelper.java: * Copyright 
(c) 2012, 2015 Oracle and/or its affiliates. All rights reserved.
java.base/share/classes/java/lang/module/package-info.java: * Copyright 
(c) 2013, 2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/classes/sun/security/util/AbstractAlgorithmConstraints.java: 
* Copyright (c) 2015, 2016 Oracle and/or its affiliates. All rights 
reserved.
java.base/share/native/libjimage/osSupport.hpp: * Copyright (c) 2015, 
2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/imageFile.hpp: * Copyright (c) 2015, 
2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/NativeImageBuffer.cpp: * Copyright (c) 
2015, 2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/inttypes.hpp: * Copyright (c) 2015, 
2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/endian.hpp: * Copyright (c) 2015, 2016 
Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/jimage.hpp: * Copyright (c) 2015, 2016 
Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/imageFile.cpp: * Copyright (c) 2015, 
2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/jimage.cpp: * Copyright (c) 2015, 2016 
Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/imageDecompressor.hpp: * Copyright (c) 
2015, 2016 Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/endian.cpp: * Copyright (c) 2015, 2016 
Oracle and/or its affiliates. All rights reserved.
java.base/share/native/libjimage/imageDecompressor.cpp: * Copyright (c) 
2015, 2016 Oracle and/or its affiliates. All rights reserved.
java.base/unix/classes/java/lang/ClassLoaderHelper.java: * Copyright (c) 
2012, 2015 Oracle and/or its affiliates. All rights reserved.
java.base/unix/classes/java/net/DefaultDatagramSocketImplFactory.java: * 
Copyright (c) 2007,2011, Oracle and/or its affiliates. All rights reserved.
java.base/windows/classes/java/lang/ClassLoaderHelper.java: * Copyright 
(c) 2012, 2015 Oracle and/or its affiliates. All rights reserved.
java.base/windows/native/libjava/jni_util_md.c: * Copyright (c) 2004, 
2014 Oracle and/or its affiliates. All rights reserved.
java.httpclient/share/classes/java/net/http/Pair.java: * Copyright (c) 
2016 Oracle and/or its affiliates. All rights reserved.
jdk.charsets/share/classes/sun/nio/cs/ext/Big5_HKSCS.java.template: * 
Copyright (c) 2010 Oracle and/or its affiliates. All rights reserved.
closed/jdk.snmp/share/classes/sun/management/snmp/resources/snmpagent.properties:# 
Copyright (c) 2015 Oracle and/or its affiliates. All rights reserved.
closed/jdk.snmp/share/classes/sun/management/snmp/SNMPConfigurationException.java: 
* Copyright (c) 2014 Oracle and/or its affiliates. All rights reserved.
sample/share/nio/chatserver/Client.java: * Copyright (c) 2011 Oracle 
and/or its affiliates. All rights reserved.
sample/share/nio/chatserver/ChatServer.java: * Copyright (c) 2011 Oracle 
and/or its affiliates. All rights reserved.
sample/share/nio/chatserver/NameReader.java: * Copyright (c) 2011 Oracle 
and/or its affiliates. All rights reserved.
sample/share/nio/chatserver/ClientReader.java: * Copyright (c) 2011 
Oracle and/or its affiliates. All rights reserved.
sample/share/nio/chatserver/DataReader.java: * Copyright (c) 2011 Oracle 
and/or its affiliates. All rights reserved.
sample/share/nio/chatserver/MessageReader.java: * Copyright (c) 2011 
Oracle and/or its affiliates. All rights reserved.

I'd prefer to see them fixed all at once, if possible.

With kind regards,
Ivan


On 05.07.2016 1:39, Aleks Efimov wrote:
> Hello,
>
> jdk/src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/package-info.java 
> file contains incorrect GPL header which fails 
> make/scripts/lic_check.sh script check.
>
> Failure is caused by missing comma after modification years. Please, 
> help to review its addition:
>     http://cr.openjdk.java.net/~aefimov/8154553/
>
> lic_check.sh passes after this modification:
>     ### Checking copyright notice in the file: 
> jdk/src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/package-info.java
>     ###
>     SUCCESS: The license header for 
> jdk/src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/package-info.java 
> has been verified.
>     ###
>
> With Best Regards,
> Aleksej
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8154553
>



More information about the core-libs-dev mailing list