JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

[Lance Andersen]

Hi Brian,
> On Jul 8, 2016, at 8:17 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> Please review at your convenience.
> 
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8160215
> Diff:
> 
> --- a/test/java/io/Reader/ReaderBulkReadContract.java
> +++ b/test/java/io/Reader/ReaderBulkReadContract.java
> @@ -148,7 +148,8 @@
> 
>     private static File createTempFileWithContents(String contents) {
>         try {
> -            File file = File.createTempFile("ReaderContract", "");
> +            File testDir = new File(System.getProperty("test.dir", "."));
> +            File file = File.createTempFile("ReaderContract", "", testDir);
>             try (FileWriter w = new FileWriter(file)) {
>                 w.write(contents);
> 
> Summary: Create temporary files in the test scratch directory instead of in the default temporary file directory.

I had issues in the past where SQE was using read only directories so writing to test.dir would fail for me.  So I used the current directory  instead which is the work directory which will get cleaned up after.

HTH

Best
Lance
> 
> Thanks,
> 
> Brian

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>