JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

Lance Andersen lance.andersen at oracle.com
Mon Jul 11 21:25:34 UTC 2016


Hi Brian,

Good to go from me :-)
> On Jul 11, 2016, at 4:38 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> On Jul 11, 2016, at 3:32 AM, Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>> wrote:
> 
>>> On Jul 11, 2016, at 3:56 AM, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>>> 
>>> On 10/07/2016 15:50, Lance Andersen wrote:
>>> 
>>>> :
>>>> I had issues in the past where SQE was using read only directories so writing to test.dir would fail for me.  So I used the current directory  instead which is the work directory which will get cleaned up after.
>>>> 
>>>> 
>>> You might be thinking `test.src` which is the path to the test source. These properties are always easy to get mixed up but there is a good table in the jtreg tag language spec [1].  In any case, I don't think jtreg sets test.dir (at least I can't see it) but it's useful to set on the command-line when running the tests outside of the test harness, I think that is what Brian is doing here.
>> 
>> Yes you are right, I was thinking of test.src.  Thanks for pointing out the updated tag info.  Nice and easy to read.
> 
> Does this fix look okay then?
> 
> Thanks,
> 
> Brian

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list