RFR(S): 8160564: TEST: Add a test to check the implementation of VersionProps.versionNumbers()
Iris Clark
iris.clark at oracle.com
Tue Jul 12 19:01:54 UTC 2016
Hi.
>> Please find the new webrev at:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/8160564.v2/
>
> +1
>
>> Any other comments?
> Only to note that this adds a validation check that we don't have
> trailing zeros, which I was recently made aware of is being
> reconsidered, see https://bugs.openjdk.java.net/browse/JDK-8156907
> - if so that implementation will likely have to revert parts of
> this validation.
I've added a comment to this effect in 8156907. That changeset will
need to include updates this code and associated regression test.
Regards,
iris
More information about the core-libs-dev
mailing list