Review request: JDK-8160398 (jdeps) Replace a list of JDK 8 internal API for detecting if it's removed in JDK 9 or later

Mandy Chung mandy.chung at oracle.com
Wed Jul 13 10:48:05 UTC 2016


> On Jul 13, 2016, at 4:55 PM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mandy,
> 
> I have not finished reviewing yet - but as early feedback I believe
> that the following probably has a mistake:
> 
> jdk.jdeps/share/classes/com/sun/tools/jdeps/Analyzer.java
> 
> 392
> 393             if (!jdk8Internals.contains(pn)) {
> 394                 return false;
> 395             }
> 396
> 397             return jdk8Internals.contains(pn);
> 
> I suspect that one of the 'pn' should be 'cn’ ?

Good catch.  The if-statement should be removed.

Mandy



More information about the core-libs-dev mailing list