RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED
David Holmes
david.holmes at oracle.com
Fri Jul 15 23:55:23 UTC 2016
Can I please get someone from AWT to approve this.
Thanks,
David
On 14/07/2016 2:25 PM, David Holmes wrote:
> The bug report for this is confidential but quite simply all of the
> little tweaks and knobs we added to the open build and source files to
> support the Java SE Embedded product no longer need to be there for JDK
> 9. Many of them have already been removed via other changes but this
> cleans up the rest.
>
> webrev: http://cr.openjdk.java.net/~dholmes/8140723/webrev.jdk/
>
> The changes relate to:
> - Java version information
> - isEmbedded() check in test code Platform.java
> - special AWT build settings for Embedded
> - special Toolkit handling for Embedded
>
> In make/lib/Awt2dLibraries.gmk I commented out a setting which was
> seemingly introduced only to support (old) embedded releases:
>
> # decimal constant is unsigned only in ISO C90 (JAVASE_EMBEDDED)
> BUILD_LIBAWT_XAWT_XToolkit.c_CFLAGS := -w
>
> which I think pertained to:
>
> #define DEF_AWT_MAX_POLL_TIMEOUT ((uint32_t)4000000000)
>
> Unless AWT folk indicate otherwise I will delete those two lines in
> final push.
>
> Thanks,
> David
> -----
More information about the core-libs-dev
mailing list