[JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

Langer, Christoph christoph.langer at sap.com
Fri Jul 22 19:23:24 UTC 2016


Hi Daniel,

looks good to me.

Maybe you'll want to take the chance to update the apache headers in the xalan files?

Best regards
Christoph

> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On Behalf
> Of Daniel Fuchs
> Sent: Freitag, 22. Juli 2016 18:16
> To: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that
> invoke addReads
> 
> Hi,
> 
> Please find below a fix for
> 8153082: Update XSTL compiler to generate classes that invoke addReads
> https://bugs.openjdk.java.net/browse/JDK-8153082
> 
> This fix removes a dependency from java.xml to an internal
> java base API.
> 
> http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.00/
> 
> It changes FunctionCall.java to generate an additional
> addReads statement before invoking a method on an external
> class.
> 
> Namely, where the generated translet class used to have
> a call to:
> 
>     com.foo.Bar.func(...);
>     (resp: new com.foo.Bar(....))
> 
> it will now also contain an additional call to Module.addReads
> to add the external's class module to the list of modules that
> the generated translet's module can read. So the generated
> code now looks like:
> 
>     <TransletClass>.class.getModule().addReads(
>                     Class.forName("com.foo.Bar").getModule());
>     com.foo.Bar.func(...);
>     (resp: new com.foo.Bar(....))
> 
> best regards,
> 
> -- daniel


More information about the core-libs-dev mailing list