RFR [9] 8157570: sun.rmi.transport.GC retains a strong reference to the context class loader ( was :8160513 )

Daniel Fuchs daniel.fuchs at oracle.com
Thu Jul 28 12:05:51 UTC 2016


Hi Chris,

Looks good to me!

best regards,

-- daniel

On 28/07/16 12:40, Chris Hegarty wrote:
> On 28 Jul 2016, at 12:28, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>>
>> On 28/07/2016 11:22, Chris Hegarty wrote:
>>
>>> [ switching to 8157570 as it better describes the issue, rather than the affect ]
>>>
>>>
>>>> Looks good to me Chris.
>>>> Another possibility might be to use InnocuousThread?
>>> Good idea Daniel. I updated the webrev to use InnocuousThread, and
>>> added an assert, since this is no test.
>>>
>>> http://cr.openjdk.java.net/~chegar/8157570/
>>>
>>>
>> This looks much better and looks good to me. Separately, should the thread name be "RMI GC Daemon" to make it a bit clearer in thread dumps.
>
> Thanks for the review Alan. Webrev updated in-place
>    http://cr.openjdk.java.net/~chegar/8157570/
>
> -Chris.
>



More information about the core-libs-dev mailing list