RFR: 8151832: Improve exception messages in exceptions thrown by jigsaw code

Alan Bateman Alan.Bateman at oracle.com
Wed Jun 1 09:21:11 UTC 2016


On 31/05/2016 18:57, Seán Coffey wrote:
>
>
> new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8151832.v2/webrev/
>
Also in JprtPath.checkPath then I assume path.getClass() is enough as 
the toString is specified to return a useful string.

In JrtPath then "nul" has been renamed to "null". I'm not sure why this 
has changed. If it is confusing the NUL (one L) should be fine.

Jim might want to comment on the jimage updates. In most cases then 
hitting any of these means the JDK is hosed. That is, if we have a bug 
here or the jimage container file is corrupted then it will likely not 
start.

In StackTraceElementCompositeData then I'm not sure if printing the 
CompositeType adds anything useful. I might be better to extract wording 
from the table in ThreadInfo.from to make it clear that the stackTrace 
attribute is missing attributes. This reminds me, I suspect this table 
might need to be updated for JDK 9. I will create a bug for that.

-Alan



More information about the core-libs-dev mailing list