RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

[Ramanand Patil]

Hi,

Please review the updated Webrev at: http://cr.openjdk.java.net/~rpatil/8153955/webrev.01/

FileHander.java and logging.properties files are updated as per Daniel's suggestion.


Regards,
Ramanand.


-----Original Message-----
From: Daniel Fuchs 
Sent: Wednesday, June 08, 2016 6:57 PM
To: Ramanand Patil; core-libs-dev at openjdk.java.net
Subject: Re: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

Hi Ramanand,

Thanks for looking into this.

1. FileHander.java:

   94  * <li>   <handler-name>.append
   95  *        specifies whether the FileHandler should append onto
   96  *        any existing files (defaults to false). </li>
   97  * <li>   java.util.FileHandler.maxLocks
   98  *        specifies the maximum number of concurrent locks hold by
   99  *        FileHandler (defaults 100). </li>

line 97: a) this is java.util.logging.FileHandler, not java.util.FileHandler.
          b) for consistency with the specification of other FileHandler
             properties I suggest to change this line to:

   97  * <li>   <handler-name>.maxLock

2. logging.properties:

   31 # Default number of locks FileHandler can obtain synchronously.
   32 # This specifies maximum number of concurrent locks by FileHandler
   33 # when the unique field %u is incremented as per the javadoc.
   34 java.util.logging.FileHandler.maxLocks = 100

Please move lines 31-34 between lines 44 and 45: that's where they belong.

best regards,

-- daniel




On 08/06/16 12:06, Ramanand Patil wrote:
> Hi all,
>
> Please review the following bug fix:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8153955
>
> Webrev: http://cr.openjdk.java.net/~rpatil/8153955/webrev.00/
>
> Fix: A new configurable java property- "java.util.logging.FileHandler.maxLocks" is added to the FileHandler which can be set in the custom logger config file. The default value of the this property will be mentioned in the default config file.(logging.properties).
>
>
>
>
>
> Regards,
>
> Ramanand.
>