RFR: 8150680 JarFile.Release enum needs reconsideration with respect to it's values
Alan Bateman
Alan.Bateman at oracle.com
Wed Jun 15 15:09:23 UTC 2016
On 15/06/2016 00:17, Steve Drach wrote:
> Hi,
>
> Please review the following changeset:
>
> webrev: http://cr.openjdk.java.net/~sdrach/8150680/webrev.00/index.html <http://cr.openjdk.java.net/~sdrach/8150680/webrev.00/index.html>
> issue: https://bugs.openjdk.java.net/browse/JDK-8150680 <https://bugs.openjdk.java.net/browse/JDK-8150680>
>
> The issue calls for reconsidering the JarFile.Release enum. A comment in the bug report suggests replacing JarFile.Release with Runtime.Version, and that’s what I did. Specifically I removed the enum, changed the constructor to accept a Runtime.Version object instead of a JarFile.Release object, updated all places in the JDK that invoked the constructor and updated all tests.
>
Moving to Runtime.Version seems right but doesn't the javadoc for the
constructor need to be updated to make it clear how it behavior when
invoking with something like Version.parse("7.1") ? If I read the code
correctly then this will be accepted and getVersion() will return 7.1.
Fields or methods is another discussion point for the base and runtime
versions.
-Alan.
More information about the core-libs-dev
mailing list