RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

David Holmes david.holmes at oracle.com
Thu Jun 16 21:11:52 UTC 2016


On 16/06/2016 10:52 PM, Claes Redestad wrote:
> On 06/16/2016 02:48 PM, Chris Hegarty wrote:
>> Apologies, you corrected me off-line,   TG.allowThreadSuspension calls
>> VM.unsuspendSomeThreads ( which is a no-op ) and not VM.unsuspendThreads
>> ( which I thought it did ).   In which case I am ok with the change.
>
> Ok, thanks! :-)

Isn't this variable unused now:

  63     boolean vmAllowSuspension;

Thanks,
David

>>
>> I think we should add ‘forRemoval = true’ while here.
>
> I'm good with that, but does modifying the way in which something is
> deprecated require a CCC request?
>
> /Claes
>
>>
>> -Chris.
>>
>>
>>> On 16 Jun 2016, at 13:39, Chris Hegarty <chris.hegarty at oracle.com>
>>> wrote:
>>>
>>> On 15 Jun 2016, at 14:30, Claes Redestad <claes.redestad at oracle.com>
>>> wrote:
>>>> Hi,
>>>>
>>>> after VM.java was encapsulated and moved from sun.misc to
>>>> jdk.internal.misc, the rationale for keeping a number of deprecated
>>>> methods and constants no longer applies and these methods should be
>>>> removed:
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~redestad/8159590/webrev.01/
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8159590
>>> I had forgotten that there was a public API, ThreadGroup, that
>>> exposed some
>>> of this functionality.  Sadly I think that we may have to keep this,
>>> for now, and
>>> remove it in 10.
>>>
>>> ThreadGroup::allowThreadSuspension should, however, have its @Deprecated
>>> annotation updated with ‘forRemoval = true’, then removed early in 10.
>>>
>>> I can’t remember if this was on Stuarts list or not, but I think it
>>> is ok to do it
>>> separately anyway.
>>>
>>> -Chris.
>


More information about the core-libs-dev mailing list