RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Pavel Rappo pavel.rappo at oracle.com
Fri Jun 17 13:57:01 UTC 2016


Roger,

> On 17 Jun 2016, at 14:14, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
> 
> Subclassing is the normal (one) way to override/augment behavior of an existing class.
> And I was looking for a minimal change since there have been many issues in this area.
> Also, I avoided the extra object and performance overhead of delegation by extending FIS.

Looks good. 

Though the code reuse in this case would've been the most of my concerns (after
the bug fix of course). I wonder how much is an extra cost per method dispatch?

As for the RFR, could you please add `@Override` annotation on top of your skip?

Thanks,
-Pavel



More information about the core-libs-dev mailing list