RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM
David Holmes
david.holmes at oracle.com
Mon Jun 20 12:42:15 UTC 2016
On 17/06/2016 10:20 PM, Claes Redestad wrote:
>
>
> On 2016-06-17 03:35, David Holmes wrote:
>> Hi Claes,
>>
>> On 17/06/2016 8:20 AM, Claes Redestad wrote:
>>>> Isn't this variable unused now:
>>>>
>>>> 63 boolean vmAllowSuspension;
>>>
>>> Interestingly enough there are hooks in hotspot to compute offsets of
>>> various fields in j.l.ThreadGroup, so even though the vmAllowSuspension
>>> field is unused (on both sides), removing the field would require
>>> changing code in hotspot.
>>>
>>> Tumbled down that rabbit hole to see how deep it goes, and was
>>> pleasantly surprised that it didn't go very far at all:
>>>
>>> HS: http://cr.openjdk.java.net/~redestad/8159590/hotspot.02/
>>> JDK: http://cr.openjdk.java.net/~redestad/8159590/jdk.02/
>>>
>>> I think the cleanup on the vm side might be trivial enough to be wrapped
>>> into this change. What do you think?
>>
>> I'd need to look into the SA code as well and double-check some
>> things. But I'm off till next week :) If you want to move ahead
>> urgently then we can file a follow up cleanup bug for hotspot.
>
> Not urgent enough to wait a few days to allow for this more thorough
> cleanup. :-)
Everything seems okay.
Thanks,
David
> /Claes
More information about the core-libs-dev
mailing list