RFR 8159245: Loggers created by system classes are not initialized correctly when configured programmatically from application code.
Hamlin Li
huaming.li at oracle.com
Wed Jun 22 06:18:09 UTC 2016
Hi Daniel,
Got you point.
Thank you
-Hamlin
On 2016/6/22 13:24, Daniel Fuchs wrote:
> Hi Hamlin,
>
> On 22/06/16 02:40, Hamlin Li wrote:
>> Just another minor comment, I'm not sure if following line is necessary
>> in Logger.java, as it's already been checked in LogManager.java line
>> 577:
>>
>> 439 if (cfg == other) return cfg;
>
> Yes, you're right - but it makes sense for the method to have it :-)
>
> The reason it's already checked in LogManager is to avoid the
> creation and invocation of a PrivilegedAction for nothing.
> If we did not need to go through that - we would just call
> mergeConfigWithSystemPeer and let the importConfig config
> method do the check.
>
> best regards,
>
> -- daniel
More information about the core-libs-dev
mailing list