[9] RFR: 8022291: Mac OS: Unexpected JavaLaunchHelper message displaying

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Jun 22 19:12:50 UTC 2016


Looks fine.

On 22.06.16 1:58, David DeHaven wrote:
>
>> JBS:
>> https://bugs.openjdk.java.net/browse/JDK-8022291
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ddehaven/8022291/jdk.0/index.html
>>
>> This actually turned out to be pretty easy to fix, I eliminated the JavaLaunchHelper class and in place of it stuffed the block it replaced into a NSBlockOperation then changed the performSelectorOnMainThread call to invoke the NSBlockOperation's start message.
>>
>> I tested against the SWT snippet (Snippet297) that was attached to the original Eclipse bug that triggered the original fix. The SWT tests I could dig up all seemed to work ok.
>>
>> Original Eclipse bug, used to verify the fix:
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=389486
>>
>>
>> This should be backported to 8u after it bakes in 9 for a bit.
>
>
> Minor update:
> http://cr.openjdk.java.net/~ddehaven/8022291/jdk.1/
>
> I put the NSAutoreleasePool back, so it's directly portable to jdk8u.
>
> -DrD-
>


-- 
Best regards, Sergey.


More information about the core-libs-dev mailing list