RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Michael Haupt michael.haupt at oracle.com
Mon Jun 27 13:08:15 UTC 2016


Hi Shilpi,

thumbs up, with one remark (see below). It seems this change would require CCC approval; please take care of the process. I will be happy to sponsor the push thereafter.

Remark: how about adding negative tests? The documentation change specifies under what circumstances IAE will be thrown, but the accompanying test does not cover these cases.

Best,

Michael

> Am 27.06.2016 um 14:22 schrieb shilpi.rastogi at oracle.com:
> 
> Hi All,
> 
> Please review fix for
> 
> https://bugs.openjdk.java.net/browse/JDK-8158169
> http://cr.openjdk.java.net/~srastogi/8158169/webrev.00/
> 
> Thanks,
> Shilpi

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany

ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the core-libs-dev mailing list