> On Jun 27, 2016, at 7:16 AM, Claes Redestad <claes.redestad at oracle.com> wrote: > > http://cr.openjdk.java.net/~redestad/8160000/webrev.4/ Looks good in general. I suggest VersionProps::build to return Optional<Integer> rather than Optional<String> and make the methods in VersionProps package-private. Mandy