RFR: 8160000: Runtime.version() cause startup regressions in 9+119

[Claes Redestad]

On 2016-06-27 18:14, Mandy Chung wrote:
>
>> On Jun 27, 2016, at 9:10 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
>>
>>
>>
>> On 2016-06-27 17:22, Mandy Chung wrote:
>>>
>>>> On Jun 27, 2016, at 7:16 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
>>>>
>>>> http://cr.openjdk.java.net/~redestad/8160000/webrev.4/
>>>
>>> Looks good in general.
>>
>> Thanks Mandy,
>>
>>> I suggest VersionProps::build to return Optional<Integer> rather than Optional<String> and make the methods in VersionProps package-private.
>>
>> Sure, but not sure public vs package-private matters much since the class is package-private?
>
> The class and methods are intended for package private use only.  Making them explicit in the declaration to show the clear intention is a plus to the reader.

Right, my concern was with introducing an inconsistency with existing code.

Cleaned up:

http://cr.openjdk.java.net/~redestad/8160000/webrev.5/

/Claes