RFR 8054213: Class name repeated in output of Type.toString()

Svetlana Nikandrova svetlana.nikandrova at oracle.com
Mon Jun 27 18:25:00 UTC 2016


Kindly reminder

On 24.06.2016 14:58, Svetlana Nikandrova wrote:
> Hello,
>
> let me try again with updated version of webrev:
> Webrev:
> http://cr.openjdk.java.net/~snikandrova/8054213/webrev.01/ 
> <http://cr.openjdk.java.net/%7Esnikandrova/8054213/webrev.01/>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8054213
>
> Many thanks goes to Sergey Ustimenko for his valuable advises. I 
> believe fix looks nicer now.
> JPRT tested.
>
> Thank you,
> Svetlana
>
> On 17.06.2016 21:45, Svetlana Nikandrova wrote:
>> Hello,
>>
>> could you please review this fix for toString() method of 
>> ParameterizedTypeImpl.
>> The problem is that when we obtain simple name of nested type shared 
>> prefix is only removed for ParameterizedType owner. We need to remove 
>> it for other cases too.
>>
>> Please note that I also changed delimiter between outer and inner 
>> class from "." to "$". I believe as "$" is usually used to separate 
>> nested class name "." looks inconsistent and confusing.
>> Let me know if you have any objections.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~msolovie/8054213/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Emsolovie/8054213/webrev.00/>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8054213
>>
>> Thank you,
>> Svetlana
>



More information about the core-libs-dev mailing list