JDK 9 RFR of JDK-8156536: Remove intermittent key from java/lang/ProcessHandle/TreeTest.java

joe darcy joe.darcy at oracle.com
Tue Jun 28 03:51:53 UTC 2016


Hi Amy,

Amended change looks fine too :-)

Thanks,

-Joe


On 6/27/2016 8:23 PM, Amy Lu wrote:
> Thank you Joe!
>
> I just realized that this test was moved to tier2 due to stability issue.
> webrev updated to move the test back to tier1.
>
> Please review: http://cr.openjdk.java.net/~amlu/8156536/webrev.01/
>
> Thanks,
> Amy
>
>
> --- old/test/TEST.groups	2016-06-28 11:18:13.000000000 +0800
> +++ new/test/TEST.groups	2016-06-28 11:18:13.000000000 +0800
> @@ -27,7 +27,6 @@
>   
>   tier1 = \
>       :jdk_lang \
> -    -java/lang/ProcessHandle/TreeTest.java \
>       :jdk_util \
>       -java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java \
>       -java/util/concurrent/forkjoin/FJExceptionTableLeak.java \
> @@ -38,7 +37,6 @@
>       tools/pack200
>   
>   tier2 = \
> -    java/lang/ProcessHandle/TreeTest.java \
>       java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java \
>       java/util/concurrent/forkjoin/FJExceptionTableLeak.java \
>       :jdk_io \
> --- old/test/java/lang/ProcessHandle/TreeTest.java	2016-06-28 11:18:14.000000000 +0800
> +++ new/test/java/lang/ProcessHandle/TreeTest.java	2016-06-28 11:18:14.000000000 +0800
> @@ -50,7 +50,6 @@
>    * @build jdk.test.lib.Utils
>    * @run testng/othervm TreeTest
>    * @summary Test counting and JavaChild.spawning and counting of Processes.
> - * @key intermittent
>    * @author Roger Riggs
>    */
>   public class TreeTest extends ProcessUtil {
>
> On 6/28/16 10:56 AM, joe darcy wrote:
>> Looks good Amy; thanks,
>>
>> -Joe
>>
>>
>> On 6/27/2016 7:28 PM, Amy Lu wrote:
>>> java/lang/ProcessHandle/TreeTest.java
>>>
>>> This test was failing intermittently. With several fixes, the last 
>>> fix available in JDK9 build 115. Till now (build 124), no open bug 
>>> (no failure reported).
>>>
>>> This patch is to remove @key intermittent from the test. Please review.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8156536
>>> webrev: http://cr.openjdk.java.net/~amlu/8156536/webrev.00/
>>>
>>>
>>> Thanks,
>>> Amy
>>>
>>>
>>> --- old/test/java/lang/ProcessHandle/TreeTest.java 2016-06-28 
>>> 10:22:34.000000000 +0800
>>> +++ new/test/java/lang/ProcessHandle/TreeTest.java 2016-06-28 
>>> 10:22:34.000000000 +0800
>>> @@ -50,7 +50,6 @@
>>>   * @build jdk.test.lib.Utils
>>>   * @run testng/othervm TreeTest
>>>   * @summary Test counting and JavaChild.spawning and counting of 
>>> Processes.
>>> - * @key intermittent
>>>   * @author Roger Riggs
>>>   */
>>>  public class TreeTest extends ProcessUtil {
>>>
>>>
>>
>



More information about the core-libs-dev mailing list