RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

shilpi.rastogi at oracle.com shilpi.rastogi at oracle.com
Tue Jun 28 07:18:04 UTC 2016


Thanks Michael!!

Please see http://cr.openjdk.java.net/~srastogi/8158169/webrev.01/

DropArgumentsTest.java has method "dropArgumentsToMatchIAEData()" which 
throws IAE.

Regards,
Shilpi

On 6/28/2016 11:30 AM, Michael Haupt wrote:
> Hi Shilpi,
>
> in that case, please make sure to give the test that already covers the IAE a @bug annotation for this issue.
>
> Thanks,
>
> Michael
>
>> Am 27.06.2016 um 17:18 schrieb "shilpi.rastogi at oracle.com" <shilpi.rastogi at oracle.com>:
>>
>> Thanks Michael and Paul for comments!!
>>
>> Yes we already have negative test cases which throws IAE.
>> This test i have added to test the scenario where pos is equal to newTpes.size() and skip is equal to target.type.parameterList.size(). (positive)
>>
>> Best Regards,
>> Shilpi
>>> On 6/27/2016 6:42 PM, Paul Sandoz wrote:
>>> Hi,
>>>
>>>
>>>> On 27 Jun 2016, at 14:22, shilpi.rastogi at oracle.com wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Please review fix for
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8158169
>>>> http://cr.openjdk.java.net/~srastogi/8158169/webrev.00/
>>> The test you added is not testing the constraints you added to the documentation? are those constraints already tested?
>>>
>>> Paul.



More information about the core-libs-dev mailing list